Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for GsDevKit/Grease issue 33 #1443

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Aug 19, 2024

Alternate implementation for #1442 which fixes the test and also avoids a GemStone-specific package for it.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.42%. Comparing base (f0dc0e9) to head (c3237af).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1443   +/-   ##
=======================================
  Coverage   49.42%   49.42%           
=======================================
  Files        9073     9073           
  Lines       80080    80086    +6     
=======================================
+ Hits        39576    39582    +6     
  Misses      40504    40504           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau merged commit 0f7d6f7 into master Aug 19, 2024
20 of 26 checks passed
@jbrichau jbrichau deleted the alternate-test-pr1442 branch August 19, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant